Upgrade cpuinfo version and update some CPU feature detection code #26598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e cpuinfo functions which are now implemented.
…ing CPUIDInfo::HasArm_SME2().
onnxruntime/core/mlas/lib/qgemm.cpp
Outdated
| #if defined(USE_KLEIDIAI) && !defined(_MSC_VER) | ||
| return ArmKleidiAI::UseSME2; | ||
| #else | ||
| return false; |
Member
There was a problem hiding this comment.
Could we add a TODO here with relevant commentary and a reminder to adjust these checks once KAI support for Windows is added ?
edgchen1
changed the title
| // Note: | ||
| // cpuinfo is using IsProcessorFeaturePresent(PF_ARM_V82_FP16_INSTRUCTIONS_AVAILABLE): | ||
| // https://github.com/pytorch/cpuinfo/blob/403d652dca4c1046e8145950b1c0997a9f748b57/src/arm/windows/init.c#L224-L225 | ||
| // However, on some systems (notably, a Windows ARM64 CI build agent), cpuinfo_has_arm_neon_fp16_arith() started to |
Member
There was a problem hiding this comment.
Should cpuinfo be notified to treat this as a regression in detection of fp16 support in their newer implementation if their new way (seemingly) doesn't detect fp16 reliably on certain Windows versions ?
Contributor
Author
There was a problem hiding this comment.
yeah, it would be good to fix it there
This was referenced Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade cpuinfo version.
Update ARM64 Windows feature detection to use cpuinfo functions which are now implemented.
Add helper function
MlasIsDynamicQGemmAvailable()to abstract away platform-specific checks.Motivation and Context
Additional ARM64 Windows feature detection was implemented in cpuinfo in this commit. Update ORT to use the newly implemented feature detection.